PARQUET-1689: [C++] Stream API: Allow for columns/rows to be skipped when reading#5797
Closed
gawain-bolton wants to merge 2 commits into
Closed
Conversation
gawain-bolton
changed the title
gawain-bolton
force-pushed
the
PARQUET-1689_stream_reader_column_row_skipping
branch
from
6f55838 to
87c11ac
Compare
emkornfield
requested changes
Nov 12, 2019
…eading Add methods to the StreamReader class to allow for columns and rows of data to be skipped. Also add helper methods for finding out: - total number of columns - total number of rows - current row - current column
gawain-bolton
force-pushed
the
PARQUET-1689_stream_reader_column_row_skipping
branch
from
87c11ac to
5ec4cca
Compare
Contributor
|
One more small comment on tests, otherwise I think this is reasonable to merge. Also, as a note, it is generally easier to review changes if you don't squash commits on every revision (when merging the merge tool will do this, and it can sometimes be easier to review individual updates). |
emkornfield
approved these changes
Nov 14, 2019
emkornfield
left a comment
emkornfield
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me.
Contributor
|
LGTM, @xhochy could you take a look over and see if you can merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add methods to the StreamReader class to allow for columns and rows of
data to be skipped.
Also add helper methods for finding out: